[PATCH] D84113: [Debuginfo] (1/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/docs/LangRef.rst:5187
+- ``DW_OP_LLVM_implicit_pointer, N`` can only appear at the
+  beginning of a ``DIExpression``, and it specifies the value of variable
+  represented by the ``DILocalVariable`` referred to by the instructions
----------------
there's an article missing .. `the variable`?


================
Comment at: llvm/docs/LangRef.rst:5188
+  beginning of a ``DIExpression``, and it specifies the value of variable
+  represented by the ``DILocalVariable`` referred to by the instructions
+  value/address operand at offset N.
----------------
`instruction's`


================
Comment at: llvm/docs/LangRef.rst:5189
+  represented by the ``DILocalVariable`` referred to by the instructions
+  value/address operand at offset N.
 
----------------
I think we could expand this a bit.
- is it illegal in a DIGlobalVariableExpression?

Maybe include an example use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84113/new/

https://reviews.llvm.org/D84113