[PATCH] D85831: [SVE] Lower fixed length vector integer ISD::SETCC operations.

Wed Aug 12 14:46:17 PDT 2020

cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-int-compares.ll:446
+
+define void @icmp_ne_v32i8(<32 x i8>* %a, <32 x i8>* %b) #0 {
+; CHECK-LABEL: icmp_ne_v32i8:
----------------
paulwalker-arm wrote:
> I believe I've covered all the combinations for the EQ tests and there should already be tests for the ISEL patterns required for SETCC_MERGE_ZERO.  For these reasons there doesn't look to be a good reason to repeat the vector combinations for each comparison type, so I'm instead just testing a single but different vector length for the following compare tests.
That sounds fair. @efriedma, are you okay with this? I suppose it can be fixed post-commit if it's a problem...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85831/new/

https://reviews.llvm.org/D85831