[PATCH] D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?

[Hamilton Tobon-Mosquera via Phabricator via llvm-commits]

hamax97 added a comment.

In D85840#2213676 <https://reviews.llvm.org/D85840#2213676>, @sstefan1 wrote:

> Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

Yes, I already did it. Sorry for not doing it before.



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:948
 
-    if (auto *I = canBeMovedUpwards(MT)) {
-      // TODO: Split call and move "issue" below I.
+    if (canBeMovedUpwards(MT) || canBeMovedDownwards(MT)) {
+      // TODO: Split runtime call.
----------------
sstefan1 wrote:
> If I'm not wrong `canBeMovedDownwards()` never returns `nullptr`?
Yes you're right. I'll it.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1005
+  CallInst *RC = MT.RuntimeCall;
+  auto *I = RC->getNextNode();
+  while (I) {
----------------
sstefan1 wrote:
> I'd put `Instruction *` here.
> Also, Maybe put it in the while condition?
Sure, I'll change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85840/new/

https://reviews.llvm.org/D85840