[llvm] e2040d3 - [ValueTracking] Support min/max intrinsics in computeConstantRange()

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2020-08-12T22:07:29+02:00
New Revision: e2040d38a1c77b1ff544f96dc6ce31894e3799f0

URL: https://github.com/llvm/llvm-project/commit/e2040d38a1c77b1ff544f96dc6ce31894e3799f0
DIFF: https://github.com/llvm/llvm-project/commit/e2040d38a1c77b1ff544f96dc6ce31894e3799f0.diff

LOG: [ValueTracking] Support min/max intrinsics in computeConstantRange()

The implementation is the same as for the SPF_* case.

Added: 
    

Modified: 
    llvm/lib/Analysis/ValueTracking.cpp
    llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 3cd90e8ece75..5b67eb58fcbd 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -6414,6 +6414,33 @@ static void setLimitsForIntrinsic(const IntrinsicInst &II, APInt &Lower,
       }
     }
     break;
+  case Intrinsic::umin:
+  case Intrinsic::umax:
+  case Intrinsic::smin:
+  case Intrinsic::smax:
+    if (!match(II.getOperand(0), m_APInt(C)) &&
+        !match(II.getOperand(1), m_APInt(C)))
+      break;
+
+    switch (II.getIntrinsicID()) {
+    case Intrinsic::umin:
+      Upper = *C + 1;
+      break;
+    case Intrinsic::umax:
+      Lower = *C;
+      break;
+    case Intrinsic::smin:
+      Lower = APInt::getSignedMinValue(Width);
+      Upper = *C + 1;
+      break;
+    case Intrinsic::smax:
+      Lower = *C;
+      Upper = APInt::getSignedMaxValue(Width) + 1;
+      break;
+    default:
+      llvm_unreachable("Must be min/max intrinsic");
+    }
+    break;
   default:
     break;
   }

diff  --git a/llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll b/llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll
index 8bb93d8245b7..98c6785827aa 100644
--- a/llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll
+++ b/llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll
@@ -1856,9 +1856,7 @@ define i8 @umin_umin_umin(i8 %x, i8 %y) {
 
 define i1 @umin_ult_
diff _const(i8 %x) {
 ; CHECK-LABEL: @umin_ult_
diff _const(
-; CHECK-NEXT:    [[M:%.*]] = call i8 @llvm.umin.i8(i8 [[X:%.*]], i8 10)
-; CHECK-NEXT:    [[C:%.*]] = icmp ult i8 [[M]], 20
-; CHECK-NEXT:    ret i1 [[C]]
+; CHECK-NEXT:    ret i1 true
 ;
   %m = call i8 @llvm.umin.i8(i8 %x, i8 10)
   %c = icmp ult i8 %m, 20
@@ -1867,9 +1865,7 @@ define i1 @umin_ult_
diff _const(i8 %x) {
 
 define i1 @umax_ugt_
diff _const(i8 %x) {
 ; CHECK-LABEL: @umax_ugt_
diff _const(
-; CHECK-NEXT:    [[M:%.*]] = call i8 @llvm.umax.i8(i8 [[X:%.*]], i8 10)
-; CHECK-NEXT:    [[C:%.*]] = icmp ugt i8 [[M]], 5
-; CHECK-NEXT:    ret i1 [[C]]
+; CHECK-NEXT:    ret i1 true
 ;
   %m = call i8 @llvm.umax.i8(i8 %x, i8 10)
   %c = icmp ugt i8 %m, 5
@@ -1878,9 +1874,7 @@ define i1 @umax_ugt_
diff _const(i8 %x) {
 
 define i1 @smin_slt_
diff _const(i8 %x) {
 ; CHECK-LABEL: @smin_slt_
diff _const(
-; CHECK-NEXT:    [[M:%.*]] = call i8 @llvm.smin.i8(i8 [[X:%.*]], i8 10)
-; CHECK-NEXT:    [[C:%.*]] = icmp slt i8 [[M]], 20
-; CHECK-NEXT:    ret i1 [[C]]
+; CHECK-NEXT:    ret i1 true
 ;
   %m = call i8 @llvm.smin.i8(i8 %x, i8 10)
   %c = icmp slt i8 %m, 20
@@ -1889,9 +1883,7 @@ define i1 @smin_slt_
diff _const(i8 %x) {
 
 define i1 @smax_sgt_
diff _const(i8 %x) {
 ; CHECK-LABEL: @smax_sgt_
diff _const(
-; CHECK-NEXT:    [[M:%.*]] = call i8 @llvm.smax.i8(i8 [[X:%.*]], i8 10)
-; CHECK-NEXT:    [[C:%.*]] = icmp sgt i8 [[M]], 5
-; CHECK-NEXT:    ret i1 [[C]]
+; CHECK-NEXT:    ret i1 true
 ;
   %m = call i8 @llvm.smax.i8(i8 %x, i8 10)
   %c = icmp sgt i8 %m, 5