[PATCH] D85851: [flang][directives] Use TableGen to generate clause unparsing

Wed Aug 12 12:53:39 PDT 2020

clementval added a comment.

In D85851#2213865 <https://reviews.llvm.org/D85851#2213865>, @kiranchandramohan wrote:

> Do you plan to update the tests?

Yeah I forgot that. Will update the patch today with updated test.

================
Comment at: flang/include/flang/Parser/parse-tree.h:3467
+  // Therefore it is declared separatly here.
+  WRAPPER_CLASS(DistSchedule, std::optional<ScalarIntExpr>);
+
----------------
kiranchandramohan wrote:
> Would it make sense to move dist_schedule out of OmpClause and have it as a separate struct?
Yeah I thought about doing that. Might make it clearer that it's a specific case and doesn't fit in the generic ones. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85851/new/

https://reviews.llvm.org/D85851