[PATCH] D84481: [flang][openacc] Handle optional end directive in combined construct

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Parser/program-parsers.cpp:80
 constexpr auto execPartLookAhead{first(actionStmt >> ok,
-    ompEndLoopDirective >> ok, openaccConstruct >> ok, openmpConstruct >> ok,
-    "ASSOCIATE ("_tok, "BLOCK"_tok, "SELECT"_tok, "CHANGE TEAM"_sptok,
-    "CRITICAL"_tok, "DO"_tok, "IF ("_tok, "WHERE ("_tok, "FORALL ("_tok)};
+    ompEndLoopDirective >> ok, accEndCombinedDirective >> ok,
+    openaccConstruct >> ok, openmpConstruct >> ok, "ASSOCIATE ("_tok,
----------------
clementval wrote:
> klausler wrote:
> > Can an OpenACC `end` directive really be the first statement in the executable part?
> Only if the user makes a big mistake. I guess same with `ompEndLoopDirective`. I'm fine to remove it. It was to do as omp loop was done. 
@klausler So should we remove both `ompEndLoopDirective` and `accEndCombinedDirective` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84481/new/

https://reviews.llvm.org/D84481