[PATCH] D85794: [WIP][llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked 2 inline comments as done.
fpetrogalli added a comment.

In D85794#2212993 <https://reviews.llvm.org/D85794#2212993>, @rengolin wrote:

> I think this is a good direction, too.
>
> I don't like implicit assumptions or magic constants, especially when the two (bool scalable and int min) are not linearly independent.

As mentioned in one of the inline replies, I'd rather avoid creating getScalable and getNonScalable methods in ElementCount. I have explained why, and proposed two alternative approaches. Let me know what you think.

> There may be some leftovers, so I suggest you do a grep for `Min >` and variations, to make sure you got all of them.

On it! Thank you for pointing this out.

> I have some comments inline but am mostly happy with it.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85794/new/

https://reviews.llvm.org/D85794