[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 12 09:40:26 PDT 2020
thakis added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:390
+ for nameless_value in nameless_values:
+ if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var, re.IGNORECASE):
+ warn("Change IR value name '%s' to prevent possible conflict with scripted FileCheck name." % (var,))
----------------
This is Py3.4+. Per https://llvm.org/docs/GettingStarted.html#id7 we still support 2.7, which is why all my bots run that, which is why this breaks my bots :) (...and everyone still using Python 2.7 locally). Can you do this some other way? Maybe just surround the re with "^..$'?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85099/new/
https://reviews.llvm.org/D85099
More information about the llvm-commits
mailing list