[PATCH] D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals

Wed Aug 12 09:05:11 PDT 2020

bd1976llvm added a comment.

In D85782#2211672 <https://reviews.llvm.org/D85782#2211672>, @bd1976llvm wrote:

> In D85782#2211636 <https://reviews.llvm.org/D85782#2211636>, @MaskRay wrote:
>
>>> GNU now recommends -fvisiblity=hidden (https://gcc.gnu.org/wiki/Visibility) so my understanding is that there will be very few STV_DEFAULT symbols.
>>
>> I am not very sure this is now recommended but is indeed a non-rare configuration we should care about.
>
> Agreed. Recommended is probably too strong.

I was sure that I had read this somewhere. From the following GCC page: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fvisibility

> -fvisibility=[default|internal|hidden|protected]
> ...It is strongly recommended that you use this in any shared objects you distribute.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85782/new/

https://reviews.llvm.org/D85782