[PATCH] D85544: [OpenMPOpt] ICV tracking for calls

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

At first, I thought it wouldn't be very useful to have AAs for multiple positions since we only interact with the function one.
Now that I actually tried to make it work, turns out it is quiet a nice clean up and makes much more sense.

I'll update shortly.



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1142
+                                                      const Instruction *I,
+                                                      Attributor &A) const = 0;
+
----------------
jdoerfert wrote:
> I am unsure about the difference of these two functions from the declarations. If we need two member functions we should name them appropriately and elaborate in the description.
With the new AAs for CSRet and Ret positions, one of those goes away and I think it will be clearer then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85544/new/

https://reviews.llvm.org/D85544