[PATCH] D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSectionXCOFF.h:67
   XCOFF::StorageClass getStorageClass() const { return QualName->getStorageClass(); }
+  XCOFF::VisibilityType getVisibilityType() const { return QualName->getVisibilityType(); }
   XCOFF::SymbolType getCSectType() const { return Type; }
----------------
nit: Address Lint comment.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:569-572
   // table entries for a detailed description. Since we don't yet support
   // visibility, and all other bits are either optionally set or reserved, this
   // is always zero.
   // TODO FIXME How to assert a symbol's visibilty is default?
----------------
These comments need to be removed or updated.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:606-609
   // table entries for a detailed description. Since we don't yet support
   // visibility, and all other bits are either optionally set or reserved, this
   // is always zero.
   // TODO FIXME How to assert a symbol's visibilty is default?
----------------
Same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84265/new/

https://reviews.llvm.org/D84265