[PATCH] D85837: [GlobalOpt] Fix incorrect Modified status

[David Stenberg via Phabricator via llvm-commits]

dstenb created this revision.
dstenb added reviewers: serge-sans-paille, t.p.northover.
Herald added subscribers: llvm-commits, jfb, hiraditya.
Herald added a project: LLVM.
dstenb requested review of this revision.

When marking a global variable constant, and simplifying users using
CleanupConstantGlobalUsers(), the pass could incorrectly return false if
there were still some uses left, and no further optimizations was done.

This was caught using the check introduced by D80916 <https://reviews.llvm.org/D80916>.

This fixes PR46749.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85837

Files:
  llvm/lib/Transforms/IPO/GlobalOpt.cpp
  llvm/test/Transforms/GlobalOpt/const-return-status-atomic.ll
  llvm/test/Transforms/GlobalOpt/const-return-status.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85837.285078.patch
Type: text/x-patch
Size: 4024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200812/3171b1e5/attachment.bin>