[PATCH] D84347: [MLIR,OpenMP] Lowering of parallel operation: proc_bind clause 2/n

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpenMPCommonGen.cpp:27
+
+static bool emitDecls(const RecordKeeper &recordKeeper, raw_ostream &os) {
+  const auto &clauses = recordKeeper.getAllDerivedDefinitions("Clause");
----------------
mehdi_amini wrote:
> Can you document this?
> I rather not reverse engineer the code to understand the contract on the input and the generated code.
> 
> 
Sure. I will document this in a patch later today.
Assuming some comments here is what is expected.  Or should it be as part of the Operation or Dialect definition?

Thanks for fixing the documentation dependency issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84347/new/

https://reviews.llvm.org/D84347