[PATCH] D83866: [SystemZ/ZOS] Additions to the build system.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/GetHostTriple.cmake:19
+    set( value "s390x-ibm-zos" )
   elseif( CMAKE_HOST_SYSTEM_NAME STREQUAL AIX )
     # We defer to dynamic detection of the host AIX version.
----------------
I am suggesting that we use `CMAKE_SYSTEM_NAME` for both the AIX and z/OS queries (i.e., we should be consistent between the two here). The `CMAKE_HOST_SYSTEM_NAME` does not always reflect the host system for a build using the compiler resulting from the current build.

@daltenty pointed out that there is a logic error for some other platforms (and that using `CMAKE_HOST_SYSTEM_NAME` is consistent with that logic error). I do not believe that adopting the logic error for AIX and z/OS is necessarily better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83866/new/

https://reviews.llvm.org/D83866