[PATCH] D85814: [X86][GlobalISel] Legalize G_ICMP results to s8.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM. Not sure I understand the question for 32 vs. 64 mode since it doesn't seem relevant for compares



================
Comment at: llvm/lib/Target/X86/X86LegalizerInfo.cpp:172
+    getActionDefinitionsBuilder(G_ICMP)
+      .legalForCartesianProduct({s8}, {s8, s16, s32, p0})
+      .clampScalar(0, s8, s8);
----------------
You'll have to do something explicitly to handle non-0 address space pointers eventually, but this is a good enough first step


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85814/new/

https://reviews.llvm.org/D85814