[PATCH] D85825: [ARM] Enabled VMLAV and Add instructions to use VMLAVA

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:216
+    Instruction *I = cast<Instruction>(&II);
+    if (I->hasOneUse()){
+      auto *User = cast<Instruction>(*I->user_begin());
----------------
Can you quickly run clang-format on the patch too


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:219
+      Value *OpZ;
+      if (match(cast<Value>(User), m_c_Add(m_Specific(I), m_Value(OpZ))) && 
+          match(I->getOperand(3), PatternMatch::m_Zero())) {
----------------
I think here you don't need the cast<Value>, if user is already an Instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85825/new/

https://reviews.llvm.org/D85825