[PATCH] D85756: [DebugInstrRef][5/9] Substitute debug value numbers to handle optimisations

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

In D85756#2211044 <https://reviews.llvm.org/D85756#2211044>, @aprantl wrote:

> Are there other targets that also need to be updated?

Probably all of them; I'm aware of at least one other x86 pass that requires a similar action (x86-fixup-bw-insts) and MachineCSE will need it too. I haven't yet looked at non-x86 targets.

I don't think I wrote this down anywhere else, but I'd like this patch to be seen as a "proof of concept" that debug instruction-numbers can / should be transferred in this way. Comprehensively dealing with all the places this action is required is a large-ish problem, which I'd prefer to address in a different patch series if possible. That means that, were this series to land today, there would be some variable locations dropped; but the work is after all in an experimental state hidden behind a flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85756/new/

https://reviews.llvm.org/D85756