[PATCH] D84770: [llvm-libtool-darwin] Add support for -arch_only

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added a comment.

In D84770#2210049 <https://reviews.llvm.org/D84770#2210049>, @sameerarora101 wrote:

> In D84770#2208826 <https://reviews.llvm.org/D84770#2208826>, @smeenai wrote:
>
>> In D84770#2204147 <https://reviews.llvm.org/D84770#2204147>, @sameerarora101 wrote:
>>
>>> I think I need to add V8 support under `llvm/include/llvm/TextAPI/MachO/Architecture.def` here:
>>>
>>>   ///
>>>   /// ARM64 architectures sorted by cpu sub type id.
>>>   ///
>>>   ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
>>>   ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)
>>>
>>> What should be the first element for that tuple in case of V8 (`arm64_v8` or `arm64v8` or maybe something else) ? Thanks.
>>
>> Hmm, what necessitates the TAPI patch? `arm64_v8` seems fine to me, though @ributzka and @cishida should weigh in there.
>
> Converting a yaml file with Subtype V8 to an object file requires this patch. I was trying to add a test for V8, but my yaml was incorrectly parsed as an object file with unknown architecture.

Ah, yes reading in tbd files as input will require this addition. I have no strong opinion, but I prefer for `arm64v8` as will cause less downstream disruption.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84770/new/

https://reviews.llvm.org/D84770