[PATCH] D85594: [MachO] Add skeletal support for DriverKit platform

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 00:07:15 PDT 2020


cishida added a comment.

In D85594#2207080 <https://reviews.llvm.org/D85594#2207080>, @gkm wrote:

> @tschuett, I prefer not to do anything that involves semantics for DriverKit, since I don't have any domain knowledge. For that matter, perhaps I shouldn't even follow-through with this diff, which I only embarked upon at your suggestion because the original author of the MachO `-platform_version` diff (I commandeered it) had a TODO comment. I can code-monkey the TBDv4 testcase via simple substitution, but what about TBDv1 .. TBDv3? IDK, and don't want to spend time determining minimum version# for DriverKit. Do you know that?

The current TextAPI library is simple reader/writer support and the referenced unit tests reflect any valid inputs to generate tbd and nothing else. IMO adding one TBDv4 test case with just the target info and install name would be good to add. I'd be happy to write the patch for it after this lands if that helps.



================
Comment at: llvm/lib/TextAPI/MachO/Platform.cpp:52
                                            : PlatformKind::watchOS;
     // TODO: add bridgeOS once in llvm::Triple
   }
----------------
DriverKit case should be included 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85594/new/

https://reviews.llvm.org/D85594



More information about the llvm-commits mailing list