[PATCH] D85701: [lld-macho] Support -rpath

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

LGTM with the renaming of the local variable.  Thanks for implementing this (it was the next item I wanted to add)!



================
Comment at: lld/MachO/Config.h:36
   std::vector<llvm::StringRef> frameworkSearchPaths;
+  std::vector<llvm::StringRef> rPaths;
   llvm::DenseMap<llvm::StringRef, SymbolPriorityEntry> priorities;
----------------
I don't think that `rPaths` is correct ... `rpaths` would be correct here, or `runtimePaths`.


================
Comment at: lld/MachO/Writer.cpp:268
+    memcpy(buf, path.data(), path.size());
+    buf[path.size()] = '\0';
+  }
----------------
I wish we could use `strlcpy`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85701/new/

https://reviews.llvm.org/D85701