[PATCH] D85024: [llvm-objdump] Implement --prefix option
Vinicius Tinti via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 19:32:49 PDT 2020
tinti updated this revision to Diff 284953.
tinti added a comment.
Reword llvm/docs/CommandGuide/llvm-objdump.rst
Keep Windows as unsupported. [1]
Use -D in FileCheck for better testing.
Put primary test on top of the file. The primary use is to fix a wrong or incomplete path.
Fix missing --check-prefix on trailing test.
Remove comments about compatibility with GNU's objdump.
Remove namespace `llvm::` where it is not needed.
Remove braces.
Add test comments.
Remove test checks that can be removed. [2]
[1] I believe this code will work fine on Windows but I have not tested.
[2] Tests are running faster.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85024/new/
https://reviews.llvm.org/D85024
Files:
llvm/docs/CommandGuide/llvm-objdump.rst
llvm/docs/llvm-objdump.1
llvm/test/tools/llvm-objdump/X86/source-interleave-absolute-paths.test
llvm/tools/llvm-objdump/llvm-objdump.cpp
llvm/tools/llvm-objdump/llvm-objdump.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85024.284953.patch
Type: text/x-patch
Size: 4567 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200812/1fae3c59/attachment.bin>
More information about the llvm-commits
mailing list