[PATCH] D85759: [SLPVectorizer] Fix regression from cost model refactoring

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 19:27:33 PDT 2020


aheejin added a comment.

I think D79941 <https://reviews.llvm.org/D79941> is //supposed// to work; what it did is move those logics into constructors of `IntrinsicCostAttributes`. For example, this constructor <https://github.com/llvm/llvm-project/blob/b0b95dab1ce21d93f3d62bc37256da9f38cff616/llvm/lib/Analysis/TargetTransformInfo.cpp#L93-L106> saves `FMF` and argument types, which are supposed to be used later in the same way. I think it'd be better to figure that out and fix it than restoring the old code? Maybe the original author @samparker has some ideas on why :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85759/new/

https://reviews.llvm.org/D85759



More information about the llvm-commits mailing list