[PATCH] D85691: lld: link libatomic if needed for Timer

Josh Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 17:43:35 PDT 2020


cuviper added a comment.

Well, I now have evidence that this may indeed try to link a nonexistent library -- a new Rust CI run failed on MSVC <https://github.com/rust-lang/rust/pull/73526#issuecomment-672397134>:

  LINK : fatal error LNK1181: cannot open input file 'atomic.lib'

I also see a positive flag `HAVE_CXX_ATOMICS64_WITH_LIB`, but it's not used in as many places, and now I don't feel confident that this is propagated the way I expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85691/new/

https://reviews.llvm.org/D85691



More information about the llvm-commits mailing list