[PATCH] D85795: [WebAssembly][AsmParser] Name missing features in error message
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 17:26:20 PDT 2020
dschuff added inline comments.
================
Comment at: llvm/test/MC/WebAssembly/missing-features.s:6
+# CHECK: error: instruction requires: simd128
+needs_simd:
+ .functype needs_simd () -> (v128)
----------------
tlively wrote:
> dschuff wrote:
> > might as well add one that requires more than one feature?
> I don't think we actually have any such instructions right now. But I'd rather keep the loop to be robust against adding any multi-feature instructions in the future.
hm, guess we missed our opportunity to define atomic SIMD loads :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85795/new/
https://reviews.llvm.org/D85795
More information about the llvm-commits
mailing list