[PATCH] D85678: [elfabi] Move elfabi related code to IFS library

[Haowei Wu via Phabricator via llvm-commits]

haowei added a comment.

In D85678#2211912 <https://reviews.llvm.org/D85678#2211912>, @MaskRay wrote:

> In D85678#2211909 <https://reviews.llvm.org/D85678#2211909>, @haowei wrote:
>
>> In D85678#2211865 <https://reviews.llvm.org/D85678#2211865>, @MaskRay wrote:
>>
>>>> This change moves ELFObjHandler and other elfabi code to a new IFS library so it can be used by both llvm-elfabi and llvm-ifs tool for reading and writing ELF objects. Previously I move it to TextAPI but it causes cyclic dependencies.
>>>
>>> I can't find any explanation why the new file hierarchy works better and why 'IFS' instead of a more specific name (.e.g InterfaceStub) is picked.
>>
>> In my first try I put it in TextAPI library and it causes a dependency loop as Object library is depends on TextAPI. Otherwise I think TextAPI is a better place for these files.
>
> I think the sole reason that Object depends on TextAPI is due to D66159 <https://reviews.llvm.org/D66159>. Have you tried contacting the author about thinking whether we should continue organizing the two libraries this way?
>
>> I am OK with `InterfaceStub` name. It explains the purpose clearer.
>
> If you look at existing library names. Abbreviation is not common, so IFS should probably be expanded.

I think the reason to put TapiFile.cpp to Object library is legit. I would probably do the same thing if I were the original author.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85678/new/

https://reviews.llvm.org/D85678