[PATCH] D85678: [elfabi] Move elfabi related code to IFS library

Haowei Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 16:46:41 PDT 2020


haowei added a comment.

In D85678#2211865 <https://reviews.llvm.org/D85678#2211865>, @MaskRay wrote:

>> This change moves ELFObjHandler and other elfabi code to a new IFS library so it can be used by both llvm-elfabi and llvm-ifs tool for reading and writing ELF objects. Previously I move it to TextAPI but it causes cyclic dependencies.
>
> I can't find any explanation why the new file hierarchy works better and why 'IFS' instead of a more specific name (.e.g InterfaceStub) is picked.

In my first try I put it in TextAPI library and it causes a dependency loop as Object library is depends on TextAPI. Otherwise I think TextAPI is a better place for these files.

I am OK with `InterfaceStub` name. It explains the purpose clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85678/new/

https://reviews.llvm.org/D85678



More information about the llvm-commits mailing list