[PATCH] D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Updating the summary should be fine.

The two new tests code-model-elf-pic-sip.ll and code-model-elf-pic-nosip.ll are a bit too long. It seems to me we just need an additional variable in test/CodeGen/X86/linux-preemption.ll and we will be good. There may be value improving test coverage but the excessive testing in  code-model-elf-pic-sip.ll and code-model-elf-pic-nosip.ll should probably go to a separate change. (I do wonder whether they duplicate existing testing)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85782/new/

https://reviews.llvm.org/D85782