[PATCH] D85220: [CodeGen] Refactor getMemBasePlusOffset & getObjectPtrOffset to accept a TypeSize

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 14:51:00 PDT 2020


arichardson added a comment.

This will cause compilation failures in our downstream fork. Is there any reason for replacing the integer overload instead of adding a TypeSize overload?
I think adding `TypeSize::Fixed(` to all call sites is not ideal since it's overly verbose and also confusing since it's an offset and not a type size.
It would have also been nice to add a motivation for the change in the commit message rather than just explaining what's changing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85220/new/

https://reviews.llvm.org/D85220



More information about the llvm-commits mailing list