[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

[Hongtao Yu via Phabricator via llvm-commits]

hoyFB marked 6 inline comments as done.
hoyFB added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1924
+
+      DenseMap<uint64_t, std::string> AllLabels;
+      if (SymbolizeOperands)
----------------
MaskRay wrote:
> I'll generally refrain from DenseMap on integer types because -1 and -2 cannot be used as DenseMap keys. I'd use unordered_map to avoid gotchas (even if in this context it may work)
Good to know -1 and -2 are not allowed to be keys with DenseMap. Changed to `unordered_map`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191