[PATCH] D71539: [SCEV] Look through trivial PHIs.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 12:22:05 PDT 2020


fhahn updated this revision to Diff 284848.
fhahn added a comment.

Strip unnecessary checks.

In D71539#2186028 <https://reviews.llvm.org/D71539#2186028>, @bmahjour wrote:

> Some of the tests added in `llvm/test/Analysis/ScalarEvolution/trivial-phis.ll` come from https://reviews.llvm.org/D71492 but don't have the same expected results. @fhahn do you plan to improve those in this patch or a subsequent patch, or were you planning to leave those to me in D71492 <https://reviews.llvm.org/D71492>?

Yes I added some of the tests from D71492 <https://reviews.llvm.org/D71492>. This patch only improves things for LCSSA phis, not for other trivial phis (multiple equal incoming values). I can look into how this fits in now as a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71539/new/

https://reviews.llvm.org/D71539

Files:
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/ScalarEvolution/solve-quadratic-i1.ll
  llvm/test/Analysis/ScalarEvolution/solve-quadratic-overflow.ll
  llvm/test/Transforms/LoopStrengthReduce/funclet.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71539.284848.patch
Type: text/x-patch
Size: 10308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200811/38b8c202/attachment.bin>


More information about the llvm-commits mailing list