[PATCH] D85681: [AArch64][SVE] Add patterns for integer mla/mls.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> I guess it depends on whether MLA hides the cost of the MUL for all implementations.

Oh, hmm, I see what you mean.  I'll restrict the pattern to match multiplies with one use.

> Personally I prefer the DAG route because it forces the creation of a _PRED node, which we'll need sooner or later when the pseudo nodes exist[1]. It will also allow us to convert mla intrinsics for the "all active" case plus fixed length code generation can use it.

I don't see why fixed-length code generation needs this; you can use similar patterns for ADD_PRED.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85681/new/

https://reviews.llvm.org/D85681