[PATCH] D85586: Force Function Attributes

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/ForceFunctionAttrs.cpp:112
+
+static bool hasForceAttributes() {
+  return !ForceAddAttributes.empty() || !ForceRemoveAttributes.empty();
----------------
kyulee wrote:
> plotfi wrote:
> > Introduce `hasForceAttributes` as a separate NFC patch. 
> Do you mean like this? Isn't it too simple without additional checks like this?
> ```
> static bool hasForceAttributes() {
>   return !ForceAttributes.empty();
> }
> ```
Yeah, just mention its to make this diff simpler. I'll approve it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85586/new/

https://reviews.llvm.org/D85586