[PATCH] D85760: [DebugInstrRef][7/9] NFC: Separate collection of machine/variable values

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:3043
+  // instructions and recording what machine value their operands refer to.
+  for (unsigned int I = 0; I < OrderToBB.size(); ++I) {
+    MachineBasicBlock &MBB = *OrderToBB[I];
----------------
can this be `for (MachineBasicBlock &MBB : OrderToBB)`  ?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:3052
+      process(MI);
+      ++CurInst;
+    }
----------------
What is CurInst used for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85760/new/

https://reviews.llvm.org/D85760