[PATCH] D85765: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 11:31:14 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/select.ll:850
 
-; FIXME: We shouldn't fold partial undef vectors when constexprs are involved.
-; We would need to prove the constexpr doesn't result in poison which we aren't
-; equiped to do yet.
 define <2 x i32> @false_undef_true_constextpr_vec(i1 %cond) {
 ; CHECK-LABEL: @false_undef_true_constextpr_vec(
----------------
This test is still being simplified so I dropped the comment. I guess isGuaranteedNotToBeUndefOrPoison has been improved?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85765/new/

https://reviews.llvm.org/D85765



More information about the llvm-commits mailing list