[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:213
+      cmp eax, dword ptr [rip + 4112]
+      jge 0x20117e <_start+0x25> 
+
----------------
Delete the trailing space


================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:217
+
+  .. code-block:: none 
+     <L0>:
----------------
Delete the trailing space


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1576
 
+static void collectLocalBranchTargets(
+    ArrayRef<uint8_t> Bytes, const MCInstrAnalysis *MIA, MCDisassembler *DisAsm,
----------------
I'm reading this function now.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1924
+
+      DenseMap<uint64_t, std::string> AllLabels;
+      if (SymbolizeOperands)
----------------
I'll generally refrain from DenseMap on integer types because -1 and -2 cannot be used as DenseMap keys. I'd use unordered_map to avoid gotchas (even if in this context it may work)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191