[PATCH] D85472: [DomTree] Extend update API to allow a post CFG view.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

This makes sense to me. I think the only missing piece is some documentation which also explains how to interpret when PostView is missing (PostView == nullptr ===> Current CFG is the implicit PostView?)



================
Comment at: llvm/include/llvm/Support/GenericDomTree.h:542-544
   /// \param Updates An unordered sequence of updates to perform. The current
   /// CFG and the reverse of these updates provides the pre-view of the CFG.
   ///
----------------
Can you update the comment?


================
Comment at: llvm/include/llvm/Support/GenericDomTree.h:550
+          Updates, /*ReverseApplyUpdates=*/true);
+      DomTreeBuilder::ApplyUpdates(*this, PreViewCFG, nullptr);
+    } else {
----------------
nit: early return and not else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85472/new/

https://reviews.llvm.org/D85472