[PATCH] D85458: Adding functionality to Stack Tracing

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Thanks for the update, almost good, see below.
Also, could you please explain what is your practical application for chopping the callstack?



================
Comment at: llvm/unittests/Support/CrashRecoveryTest.cpp:94
 
+#if !defined(_WIN32)
+TEST(CrashRecoveryTest, LimitedStackTrace) {
----------------
We're trying to avoid platform-specific includes as much as possible. In this case, you would still want to compile the code on all platforms, but dynamically skip the parts that don't work yet. So in essence, please remove the #if / #endif lines, and enclose the EXPECT_EQ into a test:
```
// FIXME: (instruct to fix the Windows implementation for PrintStackTrace)
if (!Triple(sys::getProcessTriple()).isOSWindows())
  EXPECT_EQ(...)
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85458/new/

https://reviews.llvm.org/D85458