[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction
Zhang Kang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 10:20:25 PDT 2020
ZhangKang added a comment.
In D85599#2206033 <https://reviews.llvm.org/D85599#2206033>, @efriedma wrote:
> Fixing a MachineVerifier issue by patching clang is generally wrong; if the IR is valid, the backend should do something sane with it. If the IR isn't valid, the IR Verifier should complain.
>
> Here, I'd say the IR is valid; adding a special case to the IR rules here would be a pain. So the right fix involves changing isel and/or the definitions of the the instructions in question.
Yes, after the TRAP has been handled, the program should be continued. So I have removed the isTerminator for TRAP on PPC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85599/new/
https://reviews.llvm.org/D85599
More information about the llvm-commits
mailing list