[PATCH] D85599: [Clang] Consider __builtin_trap() and __builtin_debugtrap() as terminator

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Fixing a MachineVerifier issue by patching clang is generally wrong; if the IR is valid, the backend should do something sane with it.  If the IR isn't valid, the IR Verifier should complain.

Here, I'd say the IR is valid; adding a special case to the IR rules here would be a pain.  So the right fix involves changing isel and/or the definitions of the the instructions in question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85599/new/

https://reviews.llvm.org/D85599