[PATCH] D85718: [GlobalISel] Add G_ABS

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:1505
+  case Intrinsic::abs:
+    return translateUnaryOp(TargetOpcode::G_ABS, CI, MIRBuilder);
   case Intrinsic::smul_fix:
----------------
arsenm wrote:
> This is losing the immediate field. Does the DAG do the same?
Yes but I suppose I should leave a TODO comment just like in SelectionDAG:

https://github.com/llvm/llvm-project/blob/ea8e71c3da56f76ae2ab2f9ee7afc6444408ffab/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp#L6396


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85718/new/

https://reviews.llvm.org/D85718