[PATCH] D85732: [compiler-rt][asan][test] Skipt sanitizer_common tests on Sparc

[Rainer Orth via Phabricator via llvm-commits]

ro created this revision.
ro added reviewers: eugenis, vitalybuka.
ro added a project: Sanitizers.
Herald added subscribers: Sanitizers, fedor.sergeev, mgorny, dberris, jyknight.
ro requested review of this revision.

When building on `sparc64-unknown-linux-gnu`, I found that a large number of `SanitizerCommon-asan-sparc*-Linux` tests were `FAIL`ing, like

   SanitizerCommon-asan-sparc-Linux :: Linux/aligned_alloc-alignment.cpp
  [...]
   SanitizerCommon-asan-sparcv9-Linux :: Linux/aligned_alloc-alignment.cpp
  [...]

many of them due to

  fatal error: error in backend: Function "_Z14User_OnSIGSEGViP9siginfo_tPv": over-aligned dynamic alloca not supported.

which breaks ASan on Sparc.  Currently asan is only built for the benefit of `gcc` where it does work.  However, when enabling the compilation in `compiler-rt` to make certain it continues to build, I missed `compiler-rt/test/sanitizer_common` when disabling ASan testing on Sparc (it's not yet enabled on Solaris).

This patch fixes the issue.

Tested on `sparcv9-sun-solaris2.11` with the `sanitizer_comon` testsuite enabled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85732

Files:
  compiler-rt/test/sanitizer_common/CMakeLists.txt


Index: compiler-rt/test/sanitizer_common/CMakeLists.txt
===================================================================
--- compiler-rt/test/sanitizer_common/CMakeLists.txt
+++ compiler-rt/test/sanitizer_common/CMakeLists.txt
@@ -62,6 +62,9 @@
   if(APPLE)
     darwin_filter_host_archs(${tool_toupper}_SUPPORTED_ARCH TEST_ARCH)
   endif()
+  if(${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
+  endif()
 
   # TODO(dliew): We should iterate over the different
   # Apple platforms, not just macOS.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85732.284701.patch
Type: text/x-patch
Size: 528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200811/adb0a0ad/attachment.bin>