[PATCH] D84347: [MLIR,OpenMP] Lowering of parallel operation: proc_bind clause 2/n

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:80
-#include "llvm/Frontend/OpenMP/OMPKinds.def"
-
 /// IDs for all omp runtime library ident_t flag encodings (see
----------------
kiranchandramohan wrote:
> kiranchandramohan wrote:
> > jdoerfert wrote:
> > > We can delete `OMP_PROC_BIND_KIND` from OpenMPKinds.def now, right?
> > Good Catch.
> > 
> > There is a usage in clang/lib/Basic/OpenMPKinds.cpp. I will try to remove that also.
> Removing the usage in Clang would require making changes for all Clauses having enums. Can do that as a separate patch. Is that OK?
Yes, separate patch is fine.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:92
 
+ProcBindKind getProcBindKind(llvm::StringRef Str);
+
----------------
kiranchandramohan wrote:
> jdoerfert wrote:
> > Documentation please.
> Is this a doxygen documentation you are asking for?
yes, but the functions are gone already I suppose. All functions and members and classes in lib/Frontend/OpenMP should have doxygen comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84347/new/

https://reviews.llvm.org/D84347