[PATCH] D85547: [Attributor] Provide an edge-based interface in AAIsDead

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 05:36:26 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:3196
+  DenseMap<const BasicBlock *, std::unique_ptr<DenseSet<const BasicBlock *>>>
+      AssumedLiveSuccessors;
+
----------------
Given that a block has usually 1 or 2 successors we should consider a different data structure here. I would initially think a `Set<std::pair<BasicBlock*,BasicBlock*>>` is adequate, so we collect edges that are assumed live in there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85547/new/

https://reviews.llvm.org/D85547



More information about the llvm-commits mailing list