[PATCH] D84100: [ARM] Optimize immediate selection

Tue Aug 11 05:02:08 PDT 2020

benshi001 added a comment.

In D84100#2209387 <https://reviews.llvm.org/D84100#2209387>, @samparker wrote:

> If the logic isn't needed, then yes, I'd recommend removing. Currently I'm seeing logic added for Thumb2 opcodes so I would expect some changes and testing and if that isn't case, then I guess the changes aren't needed. Looks like the ORR and EOR paths also need to be tested?

I have uploaded a new patch with tests of eor and orr.

The changes for Thumb2 are unavoidable due to the piece of code in  the critical path.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84100/new/

https://reviews.llvm.org/D84100