[PATCH] D82091: [ARM][CostModel] Select instruction costs.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:745
+  // Override cost kind at minsize.
+  if (ST->hasMinSize())
+    CostKind = TTI::TCK_CodeSize;
----------------
I feel like this should be done by the calling function, not at this level. We should try and be reliable and give the user what they ask for, at least not special case this single function for codesize.

I don't feel particularly strongly about it though, if you did feel like arguing the point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82091/new/

https://reviews.llvm.org/D82091