[PATCH] D84502: [AArch64][GlobalISel] Implement __builtin_return_address for PAC-RET

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 03:02:18 PDT 2020


chill planned changes to this revision.
chill marked an inline comment as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:4796
+        Register TmpReg = MRI.createVirtualRegister(&AArch64::GPR64RegClass);
+        MIRBuilder.buildCopy({TmpReg}, {LiveInLR});
+        MIRBuilder.buildInstr(AArch64::XPACI, {DstReg}, {TmpReg});
----------------
arsenm wrote:
> Why do you need this temporary copy?
Nevermind, the patch is completely broken, I'll work on a new version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84502/new/

https://reviews.llvm.org/D84502



More information about the llvm-commits mailing list