[PATCH] D84100: [ARM] Optimize immediate selection

Tue Aug 11 02:51:34 PDT 2020

benshi001 added a comment.

In D84100#2209170 <https://reviews.llvm.org/D84100#2209170>, @samparker wrote:

> Thanks for the test changes.
>
>> I have added tests for thumb2, however current patch does not apply to thumb2.
>
> I'm a bit confused then why there are Thumb2 changes in FoldImmediate?

I do not think there are Thumb2 changes in FoldImmediate. You can see NewUseOpc1 and NewUseOpc2 are identical
for all thumb2 related code. Actually the original NewUseOpc is enough for thumb2. So I should change it back (only) for thumb2 in FoldImmediate?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84100/new/

https://reviews.llvm.org/D84100