[PATCH] D85623: [llvm-objdump] Change a PLT decoding error to a warning

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1408
+                          " references an invalid symbol",
+                      Obj->getFileName());
+      }
----------------
MaskRay wrote:
> grimar wrote:
> > Will it be better not to consume the error and to report something like:
> > "warning: unable to read the name of a symbol for PLT entry at ....: <error message with the reason>"?
> The message is completely bogus (snowball effect after a decoding error): `st_name (0x326600) is past the end of the string tab
> le of size 0x7`
Sorry, I'm not sure I follow. Are you saying the PLT entries are bogus? In what context? Presumably that's not always the case when you get here, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85623/new/

https://reviews.llvm.org/D85623