[PATCH] D85505: [dwarf2yaml] Change the return type of dumping functions to Error.

Tue Aug 11 02:17:26 PDT 2020

grimar added a comment.

In D85505#2206258 <https://reviews.llvm.org/D85505#2206258>, @jhenderson wrote:

> In D85505#2206219 <https://reviews.llvm.org/D85505#2206219>, @Higuoxing wrote:
>
>> In D85505#2206209 <https://reviews.llvm.org/D85505#2206209>, @jhenderson wrote:
>>
>>> Right, that would be my personal preference. Limiting the scope of where errors need handling by not emitting them earlier than necessary seems beneficial to me. @grimar, any thoughts?
>>
>> I think your opinion makes more sense. Actually, some of the DWARF dumpers are fallible. We can keep the return type to be `void` by now and refactor them step by step. Then, this change can be abandoned?
>
> Yes, I think so.

Sorry, I've missed the question for me yesterday. This resolution looks fine to me either.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85505/new/

https://reviews.llvm.org/D85505