[PATCH] D85651: [LLD][ELF] - Do not produce an invalid dynamic relocation order with --shuffle-sections.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 01:09:04 PDT 2020


psmith accepted this revision.
psmith added a comment.
This revision is now accepted and ready to land.

Looks good to me. Will be worth seeing if MaskRay has any comments.



================
Comment at: lld/ELF/Writer.cpp:1443
+  // sections in the required order from the begining so that the in.relaIplt
+  // section is placed last to an output section. Here we just do not apply
+  // sorting for an output section which holds the in.relaIplt section.
----------------
typo: "to an output section" should be "in an output section" 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85651/new/

https://reviews.llvm.org/D85651



More information about the llvm-commits mailing list